Skip to content

Conversation

@joshuaellis
Copy link
Member

@joshuaellis joshuaellis commented Jan 26, 2021

Why

What

BREAKING CHANGES: we've had an internal refactor for #221, minimum supported three is 125

FEATURES: updated dependencies such as troika-three-text, added new props to components.

FIXES: Fixed spelling error & solved nextjs blob is not defined error

Checklist

  • Documentation updated
  • Storybook entry added
  • Ready to be merged

Things we want to do before release

  • Move documentation around
  • Cleanup readme
  • Update logo
  • Deprecate the drei package
  • Automate npm release
  • Min three version - 125 (add to peer deps)
  • Add Reflector component

joshuaellis and others added 30 commits January 15, 2021 10:07
* feat: setup TS for stories

* fix: eslint was ignore .storybook

* feat: add TS to storybook

* refactor: move stories to TS (WIP)

* refactor: move more stories to TS (WIP)

* refactor: src changes for TS move over

I think these were TS problems that were missed.

* fix: ContactShadows story

* refactor: move more stories to TS

* refactor: add MapControls.tsx after raising issues in three

Two errors linked to three.js:
mrdoob/three.js#21058
mrdoob/three.js#21059

* fix: TS errors for passing refs & children

* refactor: add more stories (WIP)

* fix: useContextBridge TS to accept array of children

fixed using DefinitelyTyped/DefinitelyTyped#44572 (comment) because microsoft/TypeScript#14729

* refactor: convert more stories to TS

also useGLTF does not need to declare it's type

* chore: update storybook

* fix: revert useTexture

accidentally committed a WIP change

* refactor: move stories to TS (WIP)

* refactor: revert useGLTF story

* Minor type fixes

* chore: update react-three-fiber to latest

Required for Types

* refactor: move stories to TS

* fix: shaderMaterial on init returns void, not null

* refactor: remove unnecessary type in useFBX

* refactor: type Environment stronger

there was issues with useAsset not understanding it's types....

* Fixes CSB CI (#230)

Co-authored-by: Gianmarco Simone <[email protected]>
* change: move components into core folder

* feat: add import types web & native

index points to web to avoid breaking changes(?) but also cause that's a good default.

* refactor: rollup so it looks for ts not tsx

* refactor: move Html & Loader to web folder, make folders for native & web

index points to web

* Fixes CSB CI (#230)

* [Feature] move stories to TS (#223) (#231)

* feat: setup TS for stories

* fix: eslint was ignore .storybook

* feat: add TS to storybook

* refactor: move stories to TS (WIP)

* refactor: move more stories to TS (WIP)

* refactor: src changes for TS move over

I think these were TS problems that were missed.

* fix: ContactShadows story

* refactor: move more stories to TS

* refactor: add MapControls.tsx after raising issues in three

Two errors linked to three.js:
mrdoob/three.js#21058
mrdoob/three.js#21059

* fix: TS errors for passing refs & children

* refactor: add more stories (WIP)

* fix: useContextBridge TS to accept array of children

fixed using DefinitelyTyped/DefinitelyTyped#44572 (comment) because microsoft/TypeScript#14729

* refactor: convert more stories to TS

also useGLTF does not need to declare it's type

* chore: update storybook

* fix: revert useTexture

accidentally committed a WIP change

* refactor: move stories to TS (WIP)

* refactor: revert useGLTF story

* Minor type fixes

* chore: update react-three-fiber to latest

Required for Types

* refactor: move stories to TS

* fix: shaderMaterial on init returns void, not null

* refactor: remove unnecessary type in useFBX

* refactor: type Environment stronger

there was issues with useAsset not understanding it's types....

* Fixes CSB CI (#230)

Co-authored-by: Gianmarco Simone <[email protected]>

Co-authored-by: Josh <[email protected]>

* 2.2.16

* chore: add templates (#232)

* chore: add react-dom as optional peer depency

if you're using react-native you don't need it.

* docs: update readme

* fix: fix storybook imports that should have been done before

my bad.

Co-authored-by: Gianmarco <[email protected]>
…tions

* Added THREE.Group to useAnimations types

* Small refactor

* Added useAnimations story

* Clean up storybook

* Fix null ref typing on useAnimations

* Forgot to change typing on useAnimations api

* chore: add storybook entry to README

Co-authored-by: Josh Ellis <[email protected]>
* fix: #233 Blob is undefined in SSR

* refactor: it appears Billboard is fixed

Looks like Typescript does not suck.
* fix: suggestion for fixing #242

* refactor: default should be other way round

* chore: update readme with correct spelling
* Add MeshoptDecoder support to useGLTF

* chore: move center

Co-authored-by: Josh Ellis <[email protected]>
* feat: re-create geometry on new points

* refactor: useMemo the geometry instead of useEffect
* feat: add ability to add custom scene as prop

* docs: update Environment with new feats
@vercel
Copy link

vercel bot commented Jan 26, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/pmndrs/drei/bflrubece
✅ Preview: https://drei-git-beta.pmndrs.vercel.app

@joshuaellis
Copy link
Member Author

@drcmda How were you imagining we'd move the documentation to the site? I don't mind shuffling all that around.
@gsimone i'd like to leave the logo sorting to you 👌🏼

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jan 26, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit acdab92:

Sandbox Source
cocky-jackson-j34i9 Configuration
r3f line adding points Issue #181

@joshuaellis
Copy link
Member Author

Automate npm release

Isn't this already done with tagging? Or did you want to use something like semantic-release?

@gsimone
Copy link
Member

gsimone commented Jan 26, 2021

Automate npm release

Isn't this already done with tagging? Or did you want to use something like semantic-release?

it's not automated though

@joshuaellis
Copy link
Member Author

joshuaellis commented Jan 26, 2021

semantic-release can be automated with a github action. But then you have to do a form of semantic commiting, I think you can still deploy manually if you want?

EDIT: automation ref

@joshuaellis
Copy link
Member Author

@gsimone docs plan is to move it to the docs work on the pmdrs site, do you think that's achievable? If you invite me as a maintainer I can help move over & help finish anything to get it ready?

* chore: update Three.js dependency

* refactor: remove subdivision modifier

* fix: remove use of FaceNormalsHelper as it no longer exists in Three

* fix: update typings for THREE

* fix: update modifiers to work without THREE.Geometry

* docs: update README

* chore: add Three.js peer dependency
@gsimone
Copy link
Member

gsimone commented Jan 28, 2021

@joshuaellis I can copypaste the README in the new docs, but some elements are still missing (for example the index table)

I'll give it a shot this evening

@joshuaellis
Copy link
Member Author

Sounds great, if you need any support @gsimone shout out.

* repurpose reflector, make it capable to blur

* refactor: move materials out to reduce noise & fix types

* refactor: merge beta

* fix: add child propType

* refactor: update reflector story & fix children type

* changes

* fix: shuffle types so reflectorProps come from what the material expects

* docs

Co-authored-by: Josh Ellis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

9 participants