Elevate provisional and convert macros to APIs #526
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Elevate all provisional definitions except for those in the "storage" chapter as they are not ready. Convert all utility macros to functions, except for the "static init" macros as those must be in macro form. Cleanup a few copy/paste errors discovered along the way. Signed-off-by: Ralph Castain <[email protected]>
Member
Author
|
Please use emoji reactions ON THIS COMMENT to indicate your position on this proposal.
Here are the meanings for the emojis:
|
Converting this macro to a PMIx_Value_get_number function requires a signature change - it is no longer possible to pass the C datatype for casting the result. Instead, we now pass the PMIx datatype that corresponds to the desired C casting. We also extend the function to return a new PMIX_ERR_LOST_PRECISION status when the casting can potentially cause a loss of precision - e.g., when changing from a "float" to an "int" - and a new PMIX_ERR_CHANGE_SIGN status when the casting would cause a change in sign - e.g., when changing from a negative integer to a "size_t". Signed-off-by: Ralph Castain <[email protected]>
abouteiller
reviewed
Jul 16, 2025
| %\begin{compactitemize} | ||
| %\end{compactitemize} | ||
|
|
||
| \subsection{Added Functions (Provisional)} |
Contributor
There was a problem hiding this comment.
Check for later: we may need a Added Functions subsection that summarizes promotion from provisional to stable (refer to how we did in v4)
Contributor
There was a problem hiding this comment.
LGTM overall we may still want to do that
Contributor
|
2025 ASC Q3 Voting Result: Passed (7 Yes, 0 No, 2 Abstain) |
Contributor
|
Note, for the ticket trails. This item is for "Stable" so needs 2nd vote at next quarterly. |
naughtont3
added
the
Accepted as Stable
Contributor
|
2025-Q4 Second Vote passed: 7 yes, 0 No, 0 Abstain |
Member
Author
|
@naughtont3 Can you please check off the review button? |
naughtont3
approved these changes
Oct 17, 2025
abouteiller
approved these changes
Oct 17, 2025
| %\begin{compactitemize} | ||
| %\end{compactitemize} | ||
|
|
||
| \subsection{Added Functions (Provisional)} |
Contributor
There was a problem hiding this comment.
LGTM overall we may still want to do that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Elevate all provisional definitions except for those in the "storage" chapter as they are not ready. Convert all utility macros to functions, except for the "static init" macros as those must be in macro form.
Cleanup a few copy/paste errors discovered along the way.
Refs #518