-
Notifications
You must be signed in to change notification settings - Fork 22
Provide access to resource usage for processes and nodes #521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Please use emoji reactions ON THIS COMMENT to indicate your position on this proposal.
Here are the meanings for the emojis:
|
This PR replaces the referenced one, which was woefully stale. The doc has been reorganized and heavily modified since the original proposed change. This has been updated and organized to fit within the current doc, and to address the questions that remained on the prior PR. |
@HawkmoonEternal Does this look okay to you? |
This looks great! I could imagine that extensions to the list of sampled stats (e.g., for power and energy measurements) might be necessary in the future. Adding additional struct members later should be straightforward. |
Hmmm...extending the current structs would actually require renaming them to avoid conflicts with prior implementations. I can see two alternatives:
The second is less cumbersome if all you want is the OS values, but feels somewhat odd as it implies OS values should be treated differently. The first is aesthetically nicer, but means defining a bunch of attributes - not a big deal, just looks like a bigger change - and the struct winds up using more memory due to all those string keys. Anyone have any thoughts? |
@HawkmoonEternal I opted to go with the attribute-based approach to accommodate later extensions without having to rename/deprecate structures and their associated utility functions. Seemed like the more forward-looking approach. Please see what you think. |
Operating systems typically maintain a running measure of resource utilization by active processes. This includes metrics on CPU utilization, disk accesses, memory size, and network activity. Define a set of attributes by which these these metrics can be requested and returned. Attributes are used as a means of providing for later extension to include a broader range of metrics. Signed-off-by: Ralph Castain <[email protected]>
Note from 25Q3 meeting, will allow more time for reviews/comments and bring for vote at next quarterly (25Q4). |
Operating systems typically maintain a running measure of resource
utilization by active processes. This includes metrics on CPU
utilization, disk accesses, memory size, and network activity.
Define a set of attributes by which these these metrics can be
requested and returned.
Attributes are used as a means of providing for later extension
to include a broader range of metrics.
Replaces #335