Skip to content
This repository was archived by the owner on Jan 18, 2025. It is now read-only.

Conversation

@philipstarkey
Copy link

Fixes #86 #79

Rationale

Most of the current dependency versions tested against are unsupported, while newer versions are not tested. Also, the existing CI seems to be dead (at least the badge indicates it is).

Changes

  • Dropped support for Python 3.7, Django 2.2, and Celery 4.
  • Added CI tests for Python 3.10-3.12, Django 4.0-5.0, and Celery 5.2-5.3 (existing tests against earlier Python 3.8+, Django 3.0+, and Celery 5.0+ kept)
  • Added a GitHub action workflow that runs the tox tests. This workflow will run when a PR is created/updated and when changes are pushed to the repository.
  • Remove travis config
  • Updated readme with the new requirements and changelog
  • Bumped the major version number due to the breaking changes (dropping support for older dependencies, see first point above)
  • Updated setup.py to reflect dependency support changes
  • Add vscode config exclusion to .gitignore file

Also:
- Drop support for Python 3.7, Django 2.2 and Celery 4
- Add tests for newer Python, Django, and celery.
- Update readme with chagelog and removal of travis
- Updated version number to 4.0.0 (breaking changes due to drop of older Python/Django/Celery)
- Updated PyPI metadata in preparation for a future release
- Removed travis config file
@philipstarkey
Copy link
Author

@pmac You can see the results of the GitHub action (e.g. test suite passing) here as it won't run on PRs in your repo until merged

@tartieret
Copy link
Contributor

@philipstarkey this is great thanks!

@pmclanahan would you have a few minutes to review this? It would be amazing if we could release a new version of the package compatible with Django > 4

@tartieret
Copy link
Contributor

@philipstarkey we have published a fork of this repo that includes your PR, as we need to move forward. If @pmac is available in the future we can consolidate the changes back into this repo

Here is the link to the fork: https://github.com/panevo/django-celery-email

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Is this working?

2 participants