Skip to content

Persistence fix #944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Sep 30, 2019
Merged

Persistence fix #944

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
9ecf0f4
generalize testing Browser methods to accept elements or selectors
alexcjohnson Sep 27, 2019
9d7ba78
fix for toggling persistence on/off
alexcjohnson Sep 27, 2019
8c01c83
fix for components with no (default) props
alexcjohnson Sep 27, 2019
1854450
changelog for persistence fix & testing selector/element flexibility
alexcjohnson Sep 27, 2019
457841c
test methods to clear storage, and use to try and robustify persisten…
alexcjohnson Sep 27, 2019
445e3b1
try to robustify new persistence test
alexcjohnson Sep 27, 2019
acd9a75
extra log checks
alexcjohnson Sep 30, 2019
0bd23bb
no reinstalling dash-renderer
alexcjohnson Sep 30, 2019
f96c3ec
pull back out persistence test debug code
alexcjohnson Sep 30, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,6 @@ jobs:
name: ️️🏗️ build core
command: |
. venv/bin/activate && pip install --no-cache-dir --upgrade -e . --progress-bar off && mkdir packages
python setup.py sdist && mv dist/* packages/
cd dash-renderer && renderer build && python setup.py sdist && mv dist/* ../packages/ && cd ..
git clone --depth 1 https://github.com/plotly/dash-core-components.git
cd dash-core-components && npm install --ignore-scripts && npm run build && python setup.py sdist && mv dist/* ../packages/ && cd ..
Expand Down Expand Up @@ -200,10 +199,17 @@ jobs:
- attach_workspace:
at: ~/dash
- run:
name: 🧪 Run Integration Tests
name: ️️🏗️ Install packages
command: |
. venv/bin/activate && cd packages && ls -la
find . -name "*.gz" | xargs pip install --no-cache-dir --ignore-installed && pip list | grep dash && cd ..
find . -name "*.gz" | xargs pip install --no-cache-dir --ignore-installed && cd ..
sed -i '/dash/d' requires-install.txt
pip install --no-cache-dir --ignore-installed .
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI @byronz - the issue I was having in this PR is related to the original one that led to the sed call during build-core: sometimes (seemingly at random) the dash-renderer we prepared in packages was being overwritten by a published one from PyPI - so I used essentially the same solution, but extended to dash-renderer by using the pattern /dash/d rather than /dash-/d.

Also I skipped creating a tarball for dash itself because (a) we already have everything we need here, dash has no build artifacts, and (b) that made it easier to modify its requirements.

pip list | grep dash
- run:
name: 🧪 Run Integration Tests
command: |
. venv/bin/activate
TESTFILES=$(circleci tests glob "tests/integration/**/test_*.py" | circleci tests split --split-by=timings)
pytest --headless --nopercyfinalize --junitxml=test-reports/junit_intg.xml ${TESTFILES}
- store_artifacts:
Expand Down