Skip to content

Conversation

@GeorgeKontsevik
Copy link
Contributor

Changes year of license 2021 to 2022

@alstn2468
Copy link
Contributor

alstn2468 commented Sep 20, 2022

Wouldn't it be better to change all of these as well?

@plotly/dash-component-plugins/LICENSE, @plotly/webpack-dash-dynamic-import/LICENSE

@GeorgeKontsevik
Copy link
Contributor Author

Got it. Updated

Copy link
Contributor

@alstn2468 alstn2468 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I can't modify this approved status. 🤣

Copy link
Contributor

@alstn2468 alstn2468 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I think there are a few more files that need to be modified.
I think it would be better to check the component folder as well.

@GeorgeKontsevik
Copy link
Contributor Author

Thanks, updated.

@alexcjohnson
Copy link
Collaborator

Thanks @gki98 @alstn2468 - we've actually discussed removing the year entirely, that's becoming more common, for example facebook/react#13593, Microsoft projects... but since we haven't decided on that yet, thank you for updating these!

@alexcjohnson alexcjohnson merged commit f79a276 into plotly:dev Sep 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants