Skip to content
This repository was archived by the owner on Aug 29, 2025. It is now read-only.

Async support - delay loading xlsx #554

Merged
merged 59 commits into from
Oct 21, 2019
Merged

Async support - delay loading xlsx #554

merged 59 commits into from
Oct 21, 2019

Conversation

Marc-Andre-Rivet
Copy link
Contributor

@Marc-Andre-Rivet Marc-Andre-Rivet commented Aug 22, 2019 •
edited
Loading

todo:

  • make tooltips lazy

Note: The table itself is not lazy anymore. Only xlsx is in this implementation.

@chriddyp chriddyp temporarily deployed to dash-table-review-pr-554 August 22, 2019 21:32 Inactive
@chriddyp chriddyp temporarily deployed to dash-table-review-pr-554 August 22, 2019 21:33 Inactive
@chriddyp chriddyp temporarily deployed to dash-table-review-pr-554 August 22, 2019 21:36 Inactive
@chriddyp chriddyp temporarily deployed to dash-table-review-pr-554 August 22, 2019 21:39 Inactive
@chriddyp chriddyp temporarily deployed to dash-table-review-pr-554 August 22, 2019 21:45 Inactive
@chriddyp chriddyp temporarily deployed to dash-table-review-pr-554 August 23, 2019 16:21 Inactive
@chriddyp chriddyp temporarily deployed to dash-table-review-pr-554 August 23, 2019 16:40 Inactive
@chriddyp chriddyp temporarily deployed to dash-table-review-pr-554 August 23, 2019 17:17 Inactive
@chriddyp chriddyp temporarily deployed to dash-table-review-pr-554 August 23, 2019 17:59 Inactive
@chriddyp chriddyp temporarily deployed to dash-table-review-pr-554 August 23, 2019 18:05 Inactive
@chriddyp chriddyp temporarily deployed to dash-table-review-pr-554 August 23, 2019 18:30 Inactive
@chriddyp chriddyp temporarily deployed to dash-table-review-pr-554 August 23, 2019 18:41 Inactive
@chriddyp chriddyp temporarily deployed to dash-table-review-pr-554 August 23, 2019 18:51 Inactive
@chriddyp chriddyp temporarily deployed to dash-table-review-pr-554 August 23, 2019 19:06 Inactive
@Marc-Andre-Rivet Marc-Andre-Rivet mentioned this pull request Sep 24, 2019
Merged
13 tasks
@Marc-Andre-Rivet Marc-Andre-Rivet marked this pull request as ready for review September 30, 2019 17:06
alexcjohnson
alexcjohnson reviewed Oct 1, 2019
View reviewed changes
@Marc-Andre-Rivet Marc-Andre-Rivet changed the title Experiment - Lazy loading components & 3rd party libraries Async support - delay loading xlsx Oct 15, 2019
Marc-Andre-Rivet
Marc-Andre-Rivet commented Oct 19, 2019
View reviewed changes
CHANGELOG.md
## Unreleased
### Changed
- [#554](https://github.com/plotly/dash-table/pull/554) Async loading of `xlsx` library on export

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ordering after merge was incorrect.

@Marc-Andre-Rivet
Copy link
Contributor Author

@alexcjohnson Last concerns.. changelog ordering was incorrect e0fc646 and some cleanup 0c67d00.

alexcjohnson
alexcjohnson approved these changes Oct 21, 2019
View reviewed changes
Copy link
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃 💃 💃

@Marc-Andre-Rivet Marc-Andre-Rivet merged commit 4152242 into dev Oct 21, 2019
@Marc-Andre-Rivet Marc-Andre-Rivet deleted the exp-dynamic branch October 21, 2019 17:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@alexcjohnson alexcjohnson alexcjohnson approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Marc-Andre-Rivet @alexcjohnson @chriddyp