Refactor useComponent hook to simplify component addition logic #107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removed unnecessary cloning of props when adding a component to the parent, enhancing performance and clarity. - Cleaned up commented-out code to improve maintainability and readability.
commit: |
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the useComponent hook to simplify the component addition logic by removing unnecessary prop cloning and cleaning up commented-out code.
- Removed cloning of props before calling addComponent
- Updated addComponent call to no longer accept cloned props
- Cleaned up commented-out code to improve readability
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the useComponent hook to simplify the logic for adding components and prevent the propagation of invalid props.
- Removed unnecessary cloning and passing of props to parent.addComponent
- Cleaned up commented-out code to improve clarity and maintainability
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevents invalid props being passed to the
addComponent()method which can create invalid data on a component.Fixes #103