Skip to content

Fire an event when the tween begins #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Fire an event when the tween begins #33

wants to merge 4 commits into from
+45 −0

Conversation

vmwxiong
Copy link
Contributor

@vmwxiong vmwxiong commented May 25, 2022 •
edited
Loading

This is basically to support begin able to easily cause other things to trigger during a .chain when each piece starts

I confirm I have signed the Contributor License Agreement.

chloevolley
chloevolley approved these changes May 26, 2022
View reviewed changes
Copy link

@chloevolley chloevolley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@vmwxiong
Copy link
Contributor Author

@yaustar @chloevolley Added documentation and added support for looped tweens with a loop:begin event as well.

@yaustar
Copy link
Collaborator

yaustar commented Aug 23, 2022 •
edited
Loading

Sorry, it's been a while since we've looked at this.

begin event name is fine. The loop:begin is odd as it doesn't fit any current naming scheme for the events yet.

Is loop:begin actually needed as that would be fired at the same time as loop? Logically, they are the same event

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chloevolley chloevolley chloevolley approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vmwxiong @yaustar @chloevolley