Skip to content

Export UniformBuffer #7873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 31, 2025
Merged

Export UniformBuffer #7873

merged 1 commit into from
Jul 31, 2025

Conversation

slimbuck
Copy link
Member

@slimbuck slimbuck commented Jul 31, 2025

The examples should probably use engine's exported interface to catch these missing exports.

@slimbuck slimbuck requested review from a team and Copilot July 31, 2025 15:14
@slimbuck slimbuck self-assigned this Jul 31, 2025
@slimbuck slimbuck added the area: graphics Graphics related issue label Jul 31, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR exports the UniformBuffer class from the main engine interface to make it available for external usage. The PR description indicates this change enables example code to use the engine's properly exported interface instead of potentially importing from internal paths.

  • Adds UniformBuffer to the public API exports

@slimbuck slimbuck merged commit 380e06d into playcanvas:main Jul 31, 2025
7 checks passed
@slimbuck slimbuck deleted the uniform-dev branch July 31, 2025 15:29
@mvaligursky
Copy link
Contributor

Discussed, not needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: graphics Graphics related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants