Skip to content

Unified splats - do not generate global centers array on main thread due to cost #7868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 30, 2025
Merged

Unified splats - do not generate global centers array on main thread due to cost #7868

merged 2 commits into from
Jul 30, 2025

Conversation

mvaligursky
Copy link
Contributor

@mvaligursky mvaligursky commented Jul 30, 2025 •
edited
Loading

  • instead of expensive (on mobile) centers buffer generation on main thread, the sorter worker gets centers of individual splats, and sorts directly from those, instead of copying them to a single buffer
  • updated sogs vesion of splat asset to be up to date version

@mvaligursky mvaligursky self-assigned this Jul 30, 2025
@mvaligursky mvaligursky added area: graphics Graphics related issue enhancement labels Jul 30, 2025
@mvaligursky mvaligursky requested a review from a team July 30, 2025 11:47
@mvaligursky mvaligursky merged commit bedb13f into main Jul 30, 2025
7 checks passed
@mvaligursky mvaligursky deleted the mv-centers-worker branch July 30, 2025 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willeastcott willeastcott willeastcott approved these changes

Assignees

@mvaligursky mvaligursky

Labels
area: graphics Graphics related issue enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mvaligursky @willeastcott