Skip to content

SOGS progress events #7847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 22, 2025
Merged

SOGS progress events #7847

merged 4 commits into from
Jul 22, 2025

Conversation

slimbuck
Copy link
Member

@slimbuck slimbuck commented Jul 22, 2025

This PR:

  • adds a progress option to http get which will send progress updates
  • adds the progress event to Img's _loadImageBitmap implementation
  • collate the progress events and fire them on the parent SOGS asset

Notes

  • combineProgress functionality can possibly be made available outside of sogs

@slimbuck slimbuck requested review from a team and Copilot July 22, 2025 14:48
@slimbuck slimbuck self-assigned this Jul 22, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements progress tracking functionality for SOGS (Splat Object Graphics System) assets by adding progress event handling to HTTP requests and propagating these events through the asset loading pipeline.

  • Adds progress event support to the HTTP GET method with optional progress callback
  • Integrates progress tracking into the image bitmap loading process
  • Implements progress event aggregation across multiple assets for SOGS parsing

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
src/platform/net/http.js Adds progress option parameter and event handling to HTTP GET requests
src/framework/parsers/texture/img.js Updates _loadImageBitmap to accept asset parameter and pass it as progress handler
src/framework/parsers/sogs.js Implements combineProgress utility to aggregate progress events from multiple texture assets

@slimbuck slimbuck merged commit 57fc26f into playcanvas:main Jul 22, 2025
7 checks passed
@slimbuck slimbuck deleted the progress-dev branch July 22, 2025 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants