Limit large gaussians #7781
Merged
Limit large gaussians #7781
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR reintroduces a 1024 px cap on the Gaussian kernel size to prevent excessively large kernels on high-resolution displays.
- Clamps the viewport-based kernel dimension (
vmin) to a maximum of 1024 px. - Applies the same change in both WGSL and GLSL shader variants.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/scene/shader-lib/wgsl/chunks/gsplat/vert/gsplatCorner.js | Added min(1024.0, …) clamp to vmin. |
| src/scene/shader-lib/glsl/chunks/gsplat/vert/gsplatCorner.js | Added min(1024.0, …) clamp to vmin. |
Comments suppressed due to low confidence (2)
src/scene/shader-lib/wgsl/chunks/gsplat/vert/gsplatCorner.js:49
- Update this comment to mention that
vminis also capped at 1024 px to reflect the new clamp behavior.
// Use the smaller viewport dimension to limit the kernel size relative to the screen resolution.
src/scene/shader-lib/glsl/chunks/gsplat/vert/gsplatCorner.js:48
- The comment should be extended to note that
vminis capped at 1024 px, matching the updated implementation.
// Use the smaller viewport dimension to limit the kernel size relative to the screen resolution.
willeastcott
approved these changes
Jun 19, 2025
slimbuck
added a commit
that referenced
this pull request
Jun 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #7696.
Reintroduce the 1024 pixel size limit, otherwise high resolution screens will have larger gaussians than before.