Skip to content

Shader creation no longer supplies dummy shader in none is specified #7651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 7, 2025

Conversation

mvaligursky
Copy link
Contributor

@mvaligursky mvaligursky commented May 7, 2025

  • internally, this was only used to for transform-feedback. Transform feedback handles it now.
  • no need to do WGSL solution here

@mvaligursky mvaligursky self-assigned this May 7, 2025
@mvaligursky mvaligursky added area: graphics Graphics related issue enhancement labels May 7, 2025
@mvaligursky mvaligursky requested a review from a team May 7, 2025 13:45
@willeastcott
Copy link
Contributor

Wondering if it makes sense to deprecate the TransformFeedback interface.

@mvaligursky
Copy link
Contributor Author

People use it, there's mentioned of that from time to time.

@mvaligursky mvaligursky merged commit 5f43b93 into main May 7, 2025
7 checks passed
@mvaligursky mvaligursky deleted the mv-dummy-fragment branch May 7, 2025 14:22
@Maksims
Copy link
Collaborator

Maksims commented May 8, 2025

TransformFeedback - is definitely a powerful tool, and it is clearly stated that it is supported only by WebGL2. Since WebGL1 in engine v2 is deprecated, it makes it highly available, while WebGPU is still not commercially viable due to limited support across the board, and if project uses bespoke shaders - also is complicates use of WebGPU.

Due to that reason many developers still are relying exclusively on WebGL2, and have no need/benefit from using WebGPU renderer.

So deprecating it - will definitely be intrusive and unreasonable as the system is widely used, and is a powerful.

If there will be an alternative API - some abstract system for GPU processing of buffers, that is supported by both GAPIs - then deprecating TF will be sensible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: graphics Graphics related issue enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants