Skip to content

Adds missing license header back into builds #7646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 6, 2025
Merged

Conversation

marklundin
Copy link
Member

Add banner support for UMD builds and adjust SWC comment handling

Fixes #7644

I confirm I have read the contributing guidelines and signed the Contributor License Agreement.

@marklundin marklundin requested review from mvaligursky and Copilot May 6, 2025 10:47
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR re-adds the missing license header for UMD builds by adjusting SWC comment handling and introducing a banner for UMD outputs.

  • Update SWC options to use "some" for comments when appropriate.
  • Add a conditional banner in UMD build outputs.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
utils/rollup-swc-options.mjs Update comment configuration to support partial comments.
utils/rollup-build-target.mjs Inject license header banner for UMD builds.

@marklundin marklundin merged commit e8be039 into main May 6, 2025
6 of 7 checks passed
@marklundin marklundin deleted the fix-license-export branch May 6, 2025 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Min version of engine v2 no longer contains the copyright text
2 participants