Skip to content

[Fix] More flexible Preprocessor handling of include directive #7628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 29, 2025

Conversation

mvaligursky
Copy link
Contributor

@mvaligursky mvaligursky commented Apr 29, 2025

Before, the include directive had to have end of line directly after closing quote, so this would work:

#include "endPS"

, but this would not

#include "endPS"  // comment

This PR updates regex to stop matching at the closing quite.

@mvaligursky mvaligursky self-assigned this Apr 29, 2025
@mvaligursky mvaligursky added bug area: graphics Graphics related issue labels Apr 29, 2025
@mvaligursky mvaligursky requested a review from a team April 29, 2025 14:27
@mvaligursky mvaligursky merged commit 4a6a334 into main Apr 29, 2025
7 checks passed
@mvaligursky mvaligursky deleted the mv-include-preprocessor-fix branch April 29, 2025 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: graphics Graphics related issue bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants