Skip to content

WGSL version of few internal chunks #7610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 25, 2025
Merged

WGSL version of few internal chunks #7610

merged 1 commit into from
Apr 25, 2025

Conversation

mvaligursky
Copy link
Contributor

@mvaligursky mvaligursky commented Apr 25, 2025 •
edited
Loading

  • removed and inlined tangentBinormalVS chunk to avoid having to create globals and assignments on WGSL due to not having access to output parameters globally
  • converted few additional chunks to WGSL

@mvaligursky mvaligursky self-assigned this Apr 25, 2025
@mvaligursky mvaligursky added the area: graphics Graphics related issue label Apr 25, 2025
@mvaligursky mvaligursky requested a review from a team April 25, 2025 13:20
@mvaligursky mvaligursky merged commit f60b9a2 into main Apr 25, 2025
7 checks passed
@mvaligursky mvaligursky deleted the mv-tangent-twosided-wgsl branch April 25, 2025 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willeastcott willeastcott willeastcott approved these changes

Assignees

@mvaligursky mvaligursky

Labels
area: graphics Graphics related issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mvaligursky @willeastcott