Script name casing #49
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use the scriptName property verbatim if it exists. - Convert class names to lower camel case when scriptName is not present. - Update attribute extraction to use the original name instead of the lower camel case version.
There was a problem hiding this comment.
Pull Request Overview
This PR fixes script name casing by allowing custom script names via a scriptName static field while ensuring consistent camel case formatting for class-derived names. The change addresses issue #1345 by implementing a fallback mechanism for script naming.
- Use
scriptNameproperty verbatim when present, otherwise convert class names to lower camel case - Update attribute extraction to use the processed script name instead of re-applying case conversion
- Maintain consistent naming throughout the script processing pipeline
Co-authored-by: Copilot <[email protected]>
mvaligursky
approved these changes
Jul 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes playcanvas/editor#1345.
If a
scriptNamestatic field is provided it uses that verbatim, otherwise it will used a the name of the class converted to lower camel case.