derive jason encoder for request #3182
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruslandoga
commented
Jul 24, 2023
BundleMonUnchanged files (7)
No change in files bundle size Final result: ✅ View report in BundleMon website ➡️ |
ruslandoga
commented
Jul 24, 2023
| @@ -36,6 +36,10 @@ defmodule Plausible.SentryFilter do | |||
| %{event | fingerprint: ["db_connection", reason]} | |||
| end | |||
|
|
|||
| def before_send(%{extra: %{request: %Plausible.Ingestion.Request{}}} = event) do | |||
| %{event | fingerprint: ["ingestion_request"]} | |||
| end | |||
There was a problem hiding this comment.
I'll need to try that out...
There was a problem hiding this comment.
Sentry.capture_message("oof", extra: %{request: %Plausible.Ingestion.Request{}})https://eh-uo.sentry.io/share/issue/1cb9ceadb737491f8f230c1ec391e0bf/
🥲 "shared" issue doesn't include fingerprint info...
Here's what I'm seeing on my dashboard:
Closed
ruslandoga
force-pushed
the
request-jason-encoder
branch
from
a595f74 to
c185887
Compare
ruslandoga
commented
Jul 24, 2023
| @@ -27,6 +27,7 @@ defmodule Plausible.Ingestion.Request do | |||
|
|
|||
| @max_url_size 2_000 | |||
|
|
|||
| @primary_key false | |||
There was a problem hiding this comment.
Otherwise {"id": null} is added to all requests during encoding.
ruslandoga
force-pushed
the
request-jason-encoder
branch
from
c185887 to
0e99d0d
Compare
ruslandoga
force-pushed
the
request-jason-encoder
branch
from
0e99d0d to
f05ba78
Compare
aerosol
reviewed
Jul 24, 2023
| test "enforces fingerprint for ingestion request" do | ||
| event = | ||
| Sentry.Event.create_event( | ||
| message: "oof", |
|
Great work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Continuing from #3180
Tests
Changelog
Documentation
Dark mode