Skip to content

Conversation

@gaearon
Copy link
Contributor

@gaearon gaearon commented Aug 28, 2024

Stacked on #7

This is maybe not fair to merge since it's a prerelease but just wanted to put it out there since it's a mild improvement.

This upgrades to 19 and switches to modern JSX transform.

Before (assuming #7 lands)

┌─────────┬───────┬───────┬───────┬───────┬──────────┬─────────┬───────┐
│ Stat    │ 2.5%  │ 50%   │ 97.5% │ 99%   │ Avg      │ Stdev   │ Max   │
├─────────┼───────┼───────┼───────┼───────┼──────────┼─────────┼───────┤
│ Latency │ 11 ms │ 12 ms │ 30 ms │ 36 ms │ 13.81 ms │ 5.61 ms │ 56 ms │
└─────────┴───────┴───────┴───────┴───────┴──────────┴─────────┴───────┘
┌───────────┬────────┬────────┬────────┬────────┬────────┬─────────┬────────┐
│ Stat      │ 1%     │ 2.5%   │ 50%    │ 97.5%  │ Avg    │ Stdev   │ Min    │
├───────────┼────────┼────────┼────────┼────────┼────────┼─────────┼────────┤
│ Req/Sec   │ 658    │ 658    │ 698    │ 719    │ 700.6  │ 16.99   │ 658    │
├───────────┼────────┼────────┼────────┼────────┼────────┼─────────┼────────┤
│ Bytes/Sec │ 129 MB │ 129 MB │ 137 MB │ 141 MB │ 138 MB │ 3.33 MB │ 129 MB │
└───────────┴────────┴────────┴────────┴────────┴────────┴─────────┴────────┘

After

┌─────────┬───────┬───────┬───────┬───────┬──────────┬─────────┬───────┐
│ Stat    │ 2.5%  │ 50%   │ 97.5% │ 99%   │ Avg      │ Stdev   │ Max   │
├─────────┼───────┼───────┼───────┼───────┼──────────┼─────────┼───────┤
│ Latency │ 10 ms │ 11 ms │ 30 ms │ 36 ms │ 12.67 ms │ 5.45 ms │ 55 ms │
└─────────┴───────┴───────┴───────┴───────┴──────────┴─────────┴───────┘
┌───────────┬────────┬────────┬────────┬────────┬────────┬─────────┬────────┐
│ Stat      │ 1%     │ 2.5%   │ 50%    │ 97.5%  │ Avg    │ Stdev   │ Min    │
├───────────┼────────┼────────┼────────┼────────┼────────┼─────────┼────────┤
│ Req/Sec   │ 712    │ 712    │ 769    │ 780    │ 762.8  │ 19.06   │ 712    │
├───────────┼────────┼────────┼────────┼────────┼────────┼─────────┼────────┤
│ Bytes/Sec │ 140 MB │ 140 MB │ 151 MB │ 153 MB │ 150 MB │ 3.74 MB │ 140 MB │
└───────────┴────────┴────────┴────────┴────────┴────────┴─────────┴────────┘

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Seems right to do it

@mcollina mcollina merged commit 244bcf3 into platformatic:main Aug 28, 2024
@slorber
Copy link

slorber commented Aug 28, 2024

For those interested in knowing why it improves: see the React "Fast JSX" PR here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants