Fix npm installation failure issue (issue #388) #389
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ToddKerpelman
approved these changes
Nov 3, 2022
SpencerHHurst
pushed a commit
to SpencerHHurst/quickstart
that referenced
this pull request
Jul 10, 2024
Fix npm installation failure issue (issue plaid#388)
fisherrjd
pushed a commit
to fisherrjd/quickstart
that referenced
this pull request
Oct 12, 2024
Fix npm installation failure issue (issue plaid#388)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did a little Googling and it looks like #388 is caused by a bug in react-scripts 4.0.1 that is fixed in 4.0.2. See facebook/create-react-app#9964. I was probably never able to reproduce this because I have npm 6 installed because I've never been able to get npm 7 to work properly with Artifactory, and this would most likely impact only npm 7+ users because earlier versions of npm don't care about peer deps.
If the reviewer happens to have npm 7 installed, and wants to test this...that would be cool.
This PR updates the version of react-scripts to 4.0.2.
Obligatory I-have-no-idea-what-I'm-doing-dog meme goes here.