Skip to content

fix: maybe hang for process *sshfx.ReadPacket for *Server.handle()" #624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 26, 2025
Merged

fix: maybe hang for process *sshfx.ReadPacket for *Server.handle()" #624

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9033c1b
fix: maybe hang for process *sshfx.ReadPacket for *Server.handle()"
cloudsbit Mar 25, 2025
9e64679
Update server.go
cloudsbit Mar 26, 2025
7f814d9
import slices package for server.go
cloudsbit Mar 26, 2025
c07dd7b
fix test error for server.go
cloudsbit Mar 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion server.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -699,7 +699,7 @@ func (srv *Server) handle(req sshfx.Packet, hint []byte, maxDataLen uint32) (ssh
return nil, fmt.Errorf("read length request too large: %d", req.Length)
}

n, err := file.ReadAt(hint, int64(req.Offset))
n, err := file.ReadAt(hint[:req.Length], int64(req.Offset))
if err != nil {
// We cannot return results AND a status like SSH_FX_EOF,
// so we return io.EOF only if we didn't read anything at all.
Expand Down