Skip to content

Conversation

@bianhq
Copy link
Contributor

@bianhq bianhq commented Feb 19, 2022

  1. Add the PixelsRecordSet and PixelsRecordCusor, which can be enabled/disabled by configuration properties, to pixels-presto.
  2. Update PixelsRecordReaderImpl.readBatch, let users specify whether they want to reuse the returned result row batch.

Issue #172 is not completely resolved. Record cursor is much slower than the page source for wide tables (they have similar performance on TPC-H). We also tried to implement a context (buffer) of result row batches to automatically allocate, free, and reuse the result row batches. However, it reduces the query performance a lot. This issue can be solved by implementing the read path in C++ in the future.

@bianhq bianhq added bug Something isn't working enhancement New feature or request labels Feb 19, 2022
@bianhq bianhq added this to the SQL Compatibility milestone Feb 19, 2022
@bianhq bianhq self-assigned this Feb 19, 2022
@bianhq bianhq merged commit a48c0a3 into pixelsdb:master Feb 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant