Fixing couple of warnings and making sandbox work directly with staging. #57
Conversation
filipi87
force-pushed
the
prepare_for_rn
branch
from
d87cd3b to
fa85395
Compare
filipi87
force-pushed
the
prepare_for_rn
branch
from
e6ef3bb to
48652d4
Compare
filipi87
changed the title
| } | ||
|
|
||
| export class DailyTransport extends Transport { | ||
| protected _state: TransportState = "idle"; |
There was a problem hiding this comment.
I have removed this variable from here, because it is already declared inside the abstract class Transport.
| this._abortController! | ||
| ); | ||
| } else { | ||
| // @ts-ignore |
There was a problem hiding this comment.
I keep seing this error in my IDE:
Argument type {mode: "cors", headers: {'Content-Type': string}, method: string, body: string, signal: AbortSignal | null} is not assignable to parameter type RequestInit | undefined
So, I have added it just as a workaround to stop it while I was looking at the other warnings. But I was not supposed to have commited this one.
I need to figure out why is it complaining, because it seems that everything works just fine.
| * @returns VoiceClientConfigOption[] - Updated configuration | ||
| */ | ||
| protected set config(config: VoiceClientConfigOption[]) { | ||
| public set config(config: VoiceClientConfigOption[]) { |
There was a problem hiding this comment.
This one, I was receiving a warning, regarding different access modifiers for the get and set.
But that is probably an issue from my IDE, I was just looking at this PR, and it seems it is supposed to work without any kind of warning:
microsoft/TypeScript#42425
Set accessors may be less visible than their corresponding get.
So we should remove this change for sure.
|
Closing this PR, all the relevant changes will be included at this branch: |
Uh oh!
There was an error while loading. Please reload this page.