Skip to content

rayleigh scattering: use accurate model #6135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

rayleigh scattering: use accurate model #6135

wants to merge 8 commits into from

Conversation

Mc-Pain
Copy link
Contributor

@Mc-Pain Mc-Pain commented May 21, 2025

Faster approach lead to some unpleasant render artefacts, use slower but accurate approach.

This also makes water reflect rays from skylight, bringing realistic Earth colors.

fluffyfreak
fluffyfreak reviewed May 21, 2025
View reviewed changes
fluffyfreak
fluffyfreak reviewed May 21, 2025
View reviewed changes
@fluffyfreak
Copy link
Contributor

Nice work. Would you mind giving some explanation of the above tropopause work in here just so that I can understand it.

@Mc-Pain
Copy link
Contributor Author

Mc-Pain commented May 21, 2025

Would you mind giving some explanation of the above tropopause work in here just so that I can understand it.

Model uses two different formulas for calculating pressure/density
One below tropopause (where temperature decreases with height)
One above tropopause (where temperature is constant)

The one above tropopause is not implemented yet.

@impaktor
Copy link
Member

Any pictures?

What would "slow" vs "fast" mean here, in performance? Would this put a burden on older machines that can still run pioneer?

@Mc-Pain
Copy link
Contributor Author

Mc-Pain commented May 22, 2025 •
edited
Loading

Any pictures?

#5617 (comment)

What would "slow" vs "fast" mean here, in performance? Would this put a burden on older machines that can still run pioneer?

slow - O(n^2) complexity: 8 samples for calculating density for light ray
fast - O(n) complexity: 1 sample approximating density for light ray but it looks wrong near terminator

@sturnclaw sturnclaw self-requested a review June 10, 2025 20:18
@Mc-Pain
Copy link
Contributor Author

Mc-Pain commented Jul 24, 2025

This fixes #6052

fluffyfreak
fluffyfreak reviewed Jul 24, 2025
View reviewed changes
fluffyfreak
fluffyfreak reviewed Jul 24, 2025
View reviewed changes
@fluffyfreak
Copy link
Contributor

There seem to be some commits that don't belong in this change history now

@Mc-Pain
Copy link
Contributor Author

Mc-Pain commented Jul 28, 2025

There seem to be some commits that don't belong in this change history now

fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fluffyfreak fluffyfreak fluffyfreak left review comments

@sturnclaw sturnclaw Awaiting requested review from sturnclaw

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Mc-Pain @fluffyfreak @impaktor