Skip to content

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #63662

What problem does this PR solve?

Issue Number: close #63663

Problem Summary:

What changed and how does it work?

Change vlen to int before use it as a length flag to avoid parse overflow.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR. labels Sep 23, 2025
Copy link

codecov bot commented Sep 23, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (release-8.5@1c16548). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-8.5     #63676   +/-   ##
================================================
  Coverage               ?   57.8206%           
================================================
  Files                  ?       1783           
  Lines                  ?     632962           
  Branches               ?          0           
================================================
  Hits                   ?     365983           
  Misses                 ?     242260           
  Partials               ?      24719           
Flag Coverage Δ
integration 38.2741% <40.0000%> (?)
unit 72.8101% <100.0000%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9278% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 63.4542% <0.0000%> (?)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@RidRisR
Copy link
Contributor

RidRisR commented Sep 23, 2025

/run-mysql-test

1 similar comment
@RidRisR
Copy link
Contributor

RidRisR commented Sep 23, 2025

/run-mysql-test

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 23, 2025
Copy link

ti-chi-bot bot commented Sep 23, 2025

@RidRisR: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@BornChanger
Copy link
Contributor

/retest

Copy link

ti-chi-bot bot commented Sep 23, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BornChanger, Leavrth, RidRisR

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 23, 2025
Copy link

ti-chi-bot bot commented Sep 23, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-09-23 07:03:07.23351078 +0000 UTC m=+340197.304004463: ☑️ agreed by BornChanger.
  • 2025-09-23 08:06:59.081646017 +0000 UTC m=+344029.152139733: ☑️ agreed by Leavrth.

@ti-chi-bot ti-chi-bot bot added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Sep 23, 2025
@ti-chi-bot ti-chi-bot bot merged commit bf3d84b into pingcap:release-8.5 Sep 23, 2025
30 of 39 checks passed
@ti-chi-bot ti-chi-bot bot deleted the cherry-pick-63662-to-release-8.5 branch September 23, 2025 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants