migrate test-infra to testify for `executor`

[tisonkun]

• migrate test-infra to testify for executor/write_concurrent_test.go #26160
• migrate test-infra to testify for executor/cte_test.go #27097
• migrate goroutine leak tests to goleak for executor #27404
• migrate test-infra to testify for TestTemporaryTableNoNetwork #27459
• migrate test-infra to testify for executor/aggfuncs #28074
• migrate test-infra to testify for executor/oomtest #28075
• migrate test-infra to testify for executor/seqtest #28076
• Move executor test setup code from TestT to TestMain #28440
• migrate test-infra to testify for adapter_test.go #28498
• migrate test-infra to testify for admin_test.go #28562
• migrate test-infra to testify for aggregate_test.go #28563
• migrate test-infra to testify for analyze_test.go #28564
• migrate test-infra to testify for apply_cache_test.go #28565
• migrate test-infra to testify for batch_point_get_test.go #28566
• migrate test-infra to testify for benchmark_test.go #28567
• migrate test-infra to testify for brie_test.go #28568
• migrate test-infra to testify for chunk_size_control_test.go #28569
• migrate test-infra to testify for collation_test.go #28570
• migrate test-infra to testify for concurrent_map_test.go #28571
• migrate test-infra to testify for ddl_test.go #28572
• migrate test-infra to testify for delete_test.go #28573
• migrate test-infra to testify for distsql_test.go #28574
• migrate test-infra to testify for executor_pkg_test.go #28575
• migrate test-infra to testify for executor_required_rows_test.go #28576
• migrate test-infra to testify for executor_test.go #28577
• migrate test-infra to testify for explain_test.go #28578
• migrate test-infra to testify for explain_unit_test.go #28579
• migrate test-infra to testify for explainfor_test.go #28580
• migrate test-infra to testify for grant_test.go #28581
• migrate test-infra to testify for hash_table_test.go #28582
• migrate test-infra to testify for index_advise_test.go #28583
• migrate test-infra to testify for index_lookup_join_test.go #28584
• migrate test-infra to testify for index_lookup_merge_join_test.go #28585
• migrate test-infra to testify for index_merge_reader_test.go #28586
• migrate test-infra to testify for infoschema_reader_test.go #28587
• migrate test-infra to testify for insert_test.go #28588
• migrate test-infra to testify for inspection_common_test.go #28589
• migrate test-infra to testify for inspection_result_test.go #28590
• migrate test-infra to testify for inspection_summary_test.go #28591
• migrate test-infra to testify for join_pkg_test.go #28592
• migrate test-infra to testify for join_test.go #28593
• migrate test-infra to testify for joiner_test.go #28594
• migrate test-infra to testify for memory_test.go #28595
• migrate test-infra to testify for memtable_reader_test.go #28596
• migrate test-infra to testify for merge_join_test.go #28597
• migrate test-infra to testify for metrics_reader_test.go #28598
• migrate test-infra to testify for parallel_apply_test.go #28599
• migrate test-infra to testify for partition_table_test.go #28600
• migrate test-infra to testify for pkg_test.go #28601
• migrate test-infra to testify for point_get_test.go #28602
• migrate test-infra to testify for prepared_test.go #28603
• migrate test-infra to testify for revoke_test.go #28604
• migrate test-infra to testify for rowid_test.go #28605
• migrate test-infra to testify for sample_test.go #28606
• migrate test-infra to testify for select_into_test.go #28607
• migrate test-infra to testify for set_test.go #28608
• migrate test-infra to testify for show_placement_labels_test.go #28609
• migrate test-infra to testify for show_placement_test.go #28610
• migrate test-infra to testify for show_stats_test.go #28611
• migrate test-infra to testify for show_test.go #28612
• migrate test-infra to testify for shuffle_test.go #28613
• migrate test-infra to testify for simple_test.go #28614
• migrate test-infra to testify for slow_query_test.go #28615
• migrate test-infra to testify for sort_test.go #28616
• migrate test-infra to testify for split_test.go #28617
• migrate test-infra to testify for stale_txn_test.go #28618
• migrate test-infra to testify for statement_context_test.go #28619
• migrate test-infra to testify for table_readers_required_rows_test.go #28620
• migrate test-infra to testify for tiflash_test.go #28621
• migrate test-infra to testify for trace_test.go #28622
• migrate test-infra to testify for union_scan_test.go #28623
• migrate test-infra to testify for update_test.go #28624
• migrate test-infra to testify for utils_test.go #28625
• migrate test-infra to testify for window_test.go #28626
• migrate test-infra to testify for write_test.go #28627

[tisonkun]

This package is too complex to have its own issue and we'd migrate then in multiple batches. Please comment the filename you want to do and I will update the checklist.

[unconsolable]

Some tests has both serial suite and suite, for example cte_test.go has both CTETestSuite and CTESerialTestSuite. Serial suite in pingcap/check can be replaced by suite in testify, while suite can not because parallel execution is not supported in testify.

IMO a parent test may be built and acted as SetUpSuite and TearDownSuite, and other tests are introduced by sub tests. Also stretchr/testify#1109 are working on parellel execution, which is waiting to be reviewed.

So should we wait for the upstream PR? Or propose other alternatives?

[tisonkun]

@unconsolable almost we use testify checkers only and it is viable to setup/teardown tests with go testing.

See also https://pkg.go.dev/testing#hdr-Subtests_and_Sub_benchmarks.

testify is already aware of this issue stretchr/testify#187 years ago and the author of stretchr/testify#1109 isn't one of the maintainer. I don't think they will enable this feature soon.

You can see how we migrate suite to go testing + testify previously.

[unconsolable]

Please add #27097 as a sub task

[tisonkun]

@unconsolable done. Thank you!

[unconsolable]

When migrating the tests in executor, please check the unexpected goroutine leak issues manually. See also #27103 (comment)

We don't have to add it now since there are multiple tests leak on never closing domain, etc. We will perform another pass to fix the leak problem but I'd prefer it soon after we migrate the tests. And thus during the migration, I hope the author manually check whether or not the tests leak.

etcd related leaks is somehow "expected", domain's, badger's are unexpected.

[tisonkun]

@unconsolable I hope we can enable goleak by #27405.