feat: Prioritize strict matches over paths with parameters #178
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're using NestJS in a new project which depends on Express and the router package.
We have multiple paths structured in the following way:
/controls/:uuid,/controls/executions. These two paths are part of separateControllerNestJS classes which means that we don't have much control over the order.The issue is that when
routeris trying to match the path, the/controls/:uuidcomes first and since it's expecting a string as the path parameter, the regex returns true when the requested path is/controls/executions.This PR introduces a fix for this by extending the search for other routes which match the pattern instead of exiting immediately on a match.