Skip to content

Allow overriding pkg-config #294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 25, 2024
Merged

Allow overriding pkg-config #294

merged 1 commit into from
Oct 25, 2024

Conversation

jackwilsdon
Copy link
Contributor

This change allows overriding pkg-config for cross-compilation:

make CC=aarch64-unknown-linux-gnu-gcc PKG_CONFIG=aarch64-unknown-linux-gnu-pkg-config

@mdevaev mdevaev self-assigned this Oct 25, 2024
@mdevaev mdevaev added type:feature New feature or request resolution:fixed Fixed labels Oct 25, 2024
@mdevaev
Copy link
Member

mdevaev commented Oct 25, 2024

Sure, why not.

@mdevaev mdevaev merged commit 57ae4cd into pikvm:master Oct 25, 2024
1 of 2 checks passed
@jackwilsdon jackwilsdon deleted the pkg-config-override branch October 25, 2024 20:09
@jackwilsdon
Copy link
Contributor Author

jackwilsdon commented Jan 25, 2025 •
edited
Loading

@mdevaev it seems like this change got pulled from master, was this intentional?

@mdevaev
Copy link
Member

mdevaev commented Jan 25, 2025

Weird. Please submit it again, I will accept it.

@jackwilsdon jackwilsdon mentioned this pull request Jan 25, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mdevaev mdevaev

Labels
resolution:fixed Fixed type:feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jackwilsdon @mdevaev