Skip to content

SSR: Checking window object before adding listeners #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 23, 2019
Merged

SSR: Checking window object before adding listeners #37

merged 2 commits into from
Jan 23, 2019

Conversation

jrfferreira
Copy link
Contributor

This change allows react-archer to be rendered from the server side.

pierpo
pierpo approved these changes Jan 23, 2019
View reviewed changes
Copy link
Owner

@pierpo pierpo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks for adding the test 😊

@pierpo pierpo merged commit 20c6f18 into pierpo:master Jan 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pierpo pierpo pierpo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jrfferreira @pierpo