Skip to content

Conversation

@veewee
Copy link
Contributor

@veewee veewee commented Sep 22, 2025

Q A
Type improvement
BC Break no
Fixed issues

Summary

@veewee veewee requested a review from Copilot September 22, 2025 12:43
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR modifies the PatchCollection class to provide access to the previous model during update operations. The update callback now receives both the new and previous versions of the model being updated.

  • Updated the update callback signature to accept both current and previous model data
  • Modified the internal implementation to create a lookup table for previous collection items
  • Updated test expectations to verify the previous model is correctly passed to the update callback

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
src/Collection/PatchCollection.php Modified patch method to pass previous model to update callback and added lookup functionality
tests/Unit/Collection/PatchCollectionTest.php Updated test to verify new update callback signature and behavior

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@veewee veewee merged commit 8aced3d into phpro:main Sep 22, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant