Use custom window-count based pager over pagerfanta #5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Pagerfanta always executes double queries, just to count the amount of records:
Postgres already provides us with window partitions, making it possible to select the total count directly from the main query:
https://www.postgresql.org/docs/current/tutorial-window.html
This allows us to enhance the query like this:
(which will work for any query: joined, aggregated, .... given it operates on the full query window)
Example implementation:
This implementation makes it possible to run the same pagination queries on both dbal query builder and our custom composite queries.