Travis

.travis.yml

@@ -2,15 +2,18 @@ language: php
 
 sudo: false
 
+dist: bionic
+
 cache:
   directories:
     - $HOME/.composer/cache
 
 matrix:
   include:
-    - php: 7.0
     - php: 7.1
     - php: 7.2
+    - php: 7.3
+    - php: 7.4
     - php: nightly
   allow_failures:
     - php: nightly

src/BlockStorage/v2/Models/Snapshot.php

@@ -5,12 +5,12 @@
 namespace OpenStack\BlockStorage\v2\Models;
 
 use OpenStack\Common\Resource\Alias;
-use OpenStack\Common\Resource\OperatorResource;
 use OpenStack\Common\Resource\Creatable;
 use OpenStack\Common\Resource\Deletable;
 use OpenStack\Common\Resource\HasMetadata;
 use OpenStack\Common\Resource\HasWaiterTrait;
 use OpenStack\Common\Resource\Listable;
+use OpenStack\Common\Resource\OperatorResource;
 use OpenStack\Common\Resource\Retrievable;
 use OpenStack\Common\Resource\Updateable;
 use OpenStack\Common\Transport\Utils;
@@ -85,8 +85,6 @@ public function retrieve()
 
     /**
      * @param array $userOptions {@see \OpenStack\BlockStorage\v2\Api::postSnapshots}
-     *
-     * @return Creatable
      */
     public function create(array $userOptions): Creatable
     {

src/BlockStorage/v2/Models/Volume.php

@@ -5,12 +5,12 @@
 namespace OpenStack\BlockStorage\v2\Models;
 
 use OpenStack\Common\Resource\Alias;
-use OpenStack\Common\Resource\OperatorResource;
 use OpenStack\Common\Resource\Creatable;
 use OpenStack\Common\Resource\Deletable;
 use OpenStack\Common\Resource\HasMetadata;
 use OpenStack\Common\Resource\HasWaiterTrait;
 use OpenStack\Common\Resource\Listable;
+use OpenStack\Common\Resource\OperatorResource;
 use OpenStack\Common\Resource\Retrievable;
 use OpenStack\Common\Resource\Updateable;
 use OpenStack\Common\Transport\Utils;
@@ -111,8 +111,6 @@ public function retrieve()
 
     /**
      * @param array $userOptions {@see \OpenStack\BlockStorage\v2\Api::postVolumes}
-     *
-     * @return Creatable
      */
     public function create(array $userOptions): Creatable
     {
@@ -162,8 +160,6 @@ public function parseMetadata(ResponseInterface $response): array
 
     /**
      * Update the bootable status for a volume, mark it as a bootable volume.
-     *
-     * @param bool $bootable
      */
     public function setBootable(bool $bootable = true)
     {
@@ -172,8 +168,6 @@ public function setBootable(bool $bootable = true)
 
     /**
      * Sets the image metadata for a volume.
-     *
-     * @param array $metadata
      */
     public function setImageMetadata(array $metadata)
     {

src/BlockStorage/v2/Models/VolumeType.php

@@ -4,10 +4,10 @@
 
 namespace OpenStack\BlockStorage\v2\Models;
 
-use OpenStack\Common\Resource\OperatorResource;
 use OpenStack\Common\Resource\Creatable;
 use OpenStack\Common\Resource\Deletable;
 use OpenStack\Common\Resource\Listable;
+use OpenStack\Common\Resource\OperatorResource;
 use OpenStack\Common\Resource\Updateable;
 
 /**
@@ -26,8 +26,6 @@ class VolumeType extends OperatorResource implements Listable, Creatable, Update
 
     /**
      * @param array $userOptions {@see \OpenStack\BlockStorage\v2\Api::postTypes}
-     *
-     * @return Creatable
      */
     public function create(array $userOptions): Creatable
     {

src/BlockStorage/v2/Service.php

@@ -20,8 +20,6 @@ class Service extends AbstractService
      * You must have enough volume storage quota remaining to create a volume of size requested.
      *
      * @param array $userOptions {@see Api::postVolumes}
-     *
-     * @return Volume
      */
     public function createVolume(array $userOptions): Volume
     {
@@ -33,8 +31,6 @@ public function createVolume(array $userOptions): Volume
      *
      * @param bool  $detail      if set to TRUE, more information will be returned
      * @param array $userOptions {@see Api::getVolumes}
-     *
-     * @return \Generator
      */
     public function listVolumes(bool $detail = false, array $userOptions = []): \Generator
     {
@@ -45,8 +41,6 @@ public function listVolumes(bool $detail = false, array $userOptions = []): \Gen
 
     /**
      * @param string $volumeId the UUID of the volume being retrieved
-     *
-     * @return Volume
      */
     public function getVolume(string $volumeId): Volume
     {
@@ -58,27 +52,17 @@ public function getVolume(string $volumeId): Volume
 
     /**
      * @param array $userOptions {@see Api::postTypes}
-     *
-     * @return VolumeType
      */
     public function createVolumeType(array $userOptions): VolumeType
     {
         return $this->model(VolumeType::class)->create($userOptions);
     }
 
-    /**
-     * @return \Generator
-     */
     public function listVolumeTypes(): \Generator
     {
         return $this->model(VolumeType::class)->enumerate($this->api->getTypes(), []);
     }
 
-    /**
-     * @param string $typeId
-     *
-     * @return VolumeType
-     */
     public function getVolumeType(string $typeId): VolumeType
     {
         $type = $this->model(VolumeType::class);
@@ -89,29 +73,19 @@ public function getVolumeType(string $typeId): VolumeType
 
     /**
      * @param array $userOptions {@see Api::postSnapshots}
-     *
-     * @return Snapshot
      */
     public function createSnapshot(array $userOptions): Snapshot
     {
         return $this->model(Snapshot::class)->create($userOptions);
     }
 
-    /**
-     * @return \Generator
-     */
     public function listSnapshots(bool $detail = false, array $userOptions = []): \Generator
     {
         $def = (true === $detail) ? $this->api->getSnapshotsDetail() : $this->api->getSnapshots();
 
         return $this->model(Snapshot::class)->enumerate($def, $userOptions);
     }
 
-    /**
-     * @param string $snapshotId
-     *
-     * @return Snapshot
-     */
     public function getSnapshot(string $snapshotId): Snapshot
     {
         $snapshot = $this->model(Snapshot::class);
@@ -122,10 +96,6 @@ public function getSnapshot(string $snapshotId): Snapshot
 
     /**
      * Shows A Quota for a tenant.
-     *
-     * @param string $tenantId
-     *
-     * @return QuotaSet
      */
     public function getQuotaSet(string $tenantId): QuotaSet
     {

src/Common/Api/Operation.php

@@ -44,17 +44,11 @@ public function __construct(array $definition)
         $this->params = self::toParamArray($definition['params']);
     }
 
-    /**
-     * @return string
-     */
     public function getPath(): string
     {
         return $this->path;
     }
 
-    /**
-     * @return string
-     */
     public function getMethod(): string
     {
         return $this->method;
@@ -64,8 +58,6 @@ public function getMethod(): string
      * Indicates whether this operation supports a parameter.
      *
      * @param $key The name of a parameter
-     *
-     * @return bool
      */
     public function hasParam(string $key): bool
     {
@@ -82,9 +74,6 @@ public function getParam(string $name)
         return isset($this->params[$name]) ? $this->params[$name] : null;
     }
 
-    /**
-     * @return string
-     */
     public function getJsonKey(): string
     {
         return $this->jsonKey ?: '';
@@ -95,8 +84,6 @@ public function getJsonKey(): string
      * {@see Parameter} objects.
      *
      * @param array $data A generic data array
-     *
-     * @return array
      */
     public static function toParamArray(array $data): array
     {

src/Common/Api/OperatorInterface.php

@@ -28,8 +28,6 @@ public function __construct(ClientInterface $client, ApiInterface $api);
      *
      * @param array $definition The data that dictates how the operation works
      * @param array $userValues The user-defined values that populate the request
-     *
-     * @return \Psr\Http\Message\ResponseInterface
      */
     public function execute(array $definition, array $userValues = []): ResponseInterface;
 
@@ -38,8 +36,6 @@ public function execute(array $definition, array $userValues = []): ResponseInte
      *
      * @param array $definition The data that dictates how the operation works
      * @param array $userValues The user-defined values that populate the request
-     *
-     * @return \GuzzleHttp\Promise\PromiseInterface
      */
     public function executeAsync(array $definition, array $userValues = []): PromiseInterface;
 
@@ -48,17 +44,13 @@ public function executeAsync(array $definition, array $userValues = []): Promise
      * HTTP client is also injected into the object to allow it to communicate with the remote API.
      *
      * @param array $definition The data that dictates how the operation works
-     *
-     * @return Operation
      */
     public function getOperation(array $definition): Operation;
 
     /**
      * @param string $class the name of the model class
      * @param mixed  $data  either a {@see ResponseInterface} or data array that will populate the newly
      *                      created model class
-     *
-     * @return \OpenStack\Common\Resource\ResourceInterface
      */
     public function model(string $class, $data = null): ResourceInterface;
 }

src/Common/Api/OperatorTrait.php

@@ -4,10 +4,10 @@
 
 namespace OpenStack\Common\Api;
 
-use GuzzleHttp\Promise\PromiseInterface;
-use function GuzzleHttp\uri_template;
 use GuzzleHttp\ClientInterface;
 use GuzzleHttp\Promise\Promise;
+use GuzzleHttp\Promise\PromiseInterface;
+use function GuzzleHttp\uri_template;
 use OpenStack\Common\Resource\ResourceInterface;
 use OpenStack\Common\Transport\RequestSerializer;
 use Psr\Http\Message\ResponseInterface;
@@ -99,10 +99,6 @@ public function getOperation(array $definition): Operation
     }
 
     /**
-     * @param Operation $operation
-     * @param array     $userValues
-     * @param bool      $async
-     *
      * @return mixed
      *
      * @throws \Exception