Fix number of segments of a large object #255
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an off by one error with the number of segments of large objects uploaded to Swift.
The total number of segments was determined with
round($streamSize/$segmentSize). In cases like$streamSize=24and$segmentSize=10this resulted in one segment too few that was uploaded. This has been fixed by simply omittinground(). I also updated the test which did not fail before by pure chance.