-
Notifications
You must be signed in to change notification settings - Fork 160
Add Server::resetState method #196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
haphan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @laszlof. Only a few minor changes needed.
src/Compute/v2/Models/Server.php
Outdated
| */ | ||
| public function resetState() | ||
| { | ||
| $response = $this->execute($this->api->resetServerState(), [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove $response
src/Compute/v2/Params.php
Outdated
| ]); | ||
| } | ||
|
|
||
| public function osResetState(): array |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use resetState
src/Compute/v2/Api.php
Outdated
| 'path' => 'servers/{id}/action', | ||
| 'params' => [ | ||
| 'id' => $this->params->urlId('server'), | ||
| 'resetState' => $this->params->osResetState() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use resetState
|
@laszlof I left some minor change requests :) |
|
Yup, saw. Was away for the weekend, will take a look today.
On Feb 5, 2018 12:18 AM, "Ha Phan" <[email protected]> wrote:
@laszlof <https://github.com/laszlof> I left some minor change requests :)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#196 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABault_SfsxAkoL3eXq2bYbOpKuJKj_bks5tRo85gaJpZM4RrscZ>
.
|
|
@haphan The issues have been corrected. |
Add functionality to reset the state of a VM.