Fix issue with retrieving FloatingIP #195
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haphan
requested changes
Jan 23, 2018
| public function retrieve() | ||
| { | ||
| $this->executeWithState($this->api->getFloatingIp()); | ||
| $response = $this->execute($this->api->getFloatingIp(), |
Collaborator
There was a problem hiding this comment.
Shouldn't this equivalent to the following?
$response = $this->executeWithState($this->api->getFloatingIp());
Contributor
Author
There was a problem hiding this comment.
Yes, looks like it is same. I guided myself more by other models in this project, for example:
https://github.com/php-opencloud/openstack/blob/master/src/Networking/v2/Models/Network.php#L53
https://github.com/php-opencloud/openstack/blob/master/src/Networking/v2/Models/Port.php#L149
And so on.
Contributor
Author
There was a problem hiding this comment.
Looks like your suggestion is much more cleaner, I will do changes.
Collaborator
|
Good catch @Jahsis. |
Contributor
Author
|
@haphan please, check my changes. |
haphan
approved these changes
Jan 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue with retrieving FloatingIP data. Previously retrieved only object without populated data.