Skip to content

feat: adds NotFoundException when file does not exit #853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 30, 2023
Merged

feat: adds NotFoundException when file does not exit #853

merged 2 commits into from
Nov 30, 2023

Conversation

playmono
Copy link
Contributor

@playmono playmono commented Nov 17, 2023 •
edited
Loading

This is very helpful to catch NotFoundException errors and return 404 to the user.

@mlocati
Copy link
Collaborator

mlocati commented Nov 17, 2023 •
edited
Loading

For backward compatibility, I'd make the new NotFoundException exception extending Imagine\Exception\InvalidArgumentException

@mlocati mlocati merged commit 922e032 into php-imagine:develop Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@playmono @mlocati