Fix undefined method error with older PHP versions #713
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `imageantialias` is generally available after PHP 7.2.0. For versions before that, this check is needed.
|
Could also be a good idea to add one CI environment which uses a PHP version below 7.2.0 and has been compiled without GD, in which case this function could be unavailable. |
|
For clarification to other reviewers: PHP can be configured to use the bundled GD version ( Before PHP 7.2 the |
ausi
approved these changes
Jul 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
imageantialiasis generally available after PHP 7.2.0. For versions before that, this check is needed.