Skip to content

perf: Optimize DuplicateCodeAnalyzer performance by removing expensive operations from hot path #989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Sep 7, 2025
Merged

perf: Optimize DuplicateCodeAnalyzer performance by removing expensive operations from hot path #989

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
6ab834e
Initial plan
Copilot Sep 7, 2025
effeb03
Optimize DuplicateCodeAnalyzer performance by implementing lazy evalu…
Copilot Sep 7, 2025
e5b1619
Investigate false positives in DuplicateCodeAnalyzer optimization
Copilot Sep 7, 2025
546ec4a
Add comprehensive test for dogfood false positives
Copilot Sep 7, 2025
36d607b
Fix false positives by reverting lazy evaluation while keeping perfor…
Copilot Sep 7, 2025
7000f4d
Merge branch 'main' into copilot/fix-988
bcollamore Sep 7, 2025
51a58a3
Fix test method naming to comply with PH2000 analyzer rule
Copilot Sep 7, 2025
26234c8
Revert AvoidDuplicateCodeAnalyzerTest.cs to original state
Copilot Sep 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions Philips.CodeAnalysis.DuplicateCodeAnalyzer/AvoidDuplicateCodeAnalyzer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,8 +153,6 @@ public void AnalyzeMethod(SyntaxNodeAnalysisContext obj)

foreach (SyntaxToken token in body.DescendantTokens())
{
_ = GetShapeDetails(token);

// For every set of token_count contiguous tokens, create a hash and add it to a dictionary with some evidence.
(var hash, Evidence evidence) = rollingTokenSet.Add(new TokenInfo(token));

Expand Down
Loading