fix #1551 - detect mouseup on tilesprites #1580
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Well spotted, thanks. |
photonstorm
added a commit
that referenced
this pull request
Feb 3, 2015
fix #1551 - detect mouseup on tilesprites
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although the git diff might look a bit misleading (because the two branches share some pieces of code), all that is done is actually just change the order of the branches, so that
displayObjectis first checked if it's an intance of aPhaser.TileSprite(if so execute it's branch which remained unmodified), and if it isn't aPhaser.TileSprite, check if it's an instance ofPIXI.Sprite(and do the same, code unchanged within the branch).I guess the issue happened because
Phaser.TileSpriteis a subclass ofPIXI.Sprite, so it got catched in the if check.