Text - font components can be specified as part of "style" #1375
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fulfills: phaserjs#1370 This allows `fontSize` and `fontWeight` to be specified as part of the style as supplied to the Text constructor (and `setStyle` method). In addition the `fontStyle` and `fontVariant` properties can also be set - although these are not exposed later. This also fixes edge cases that could be caused if `Text#fontSize` was used without `Text#fontWeight`, where the applied style defaults would be overwritten/reset.
Added `cssFont`, `fontStyle`, and `fontVariant` properties for better consistency and control.
Some minor cleanup of font component handling and comments. Also adds a warning if an "unparsable font" string is encountered. Might save someone some trouble.
photonstorm
added a commit
that referenced
this pull request
Feb 11, 2015
Text - font components can be specified as part of "style"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a breaking change in that the
fontWeightnow only handles the CSSfont-weightcomponent. ThefontStyleproperty handles 'italic', 'oblique', values fromfont-style. This makes the overall consistency cleaner but some code may need to be updated. This does not affect font-weight/font-style as withsetStyle({font:..}).Fulfills wish: #1370
Also fixes overwrite font/size/weight oddities - which may result in different behavior for code that was relying on such. All of the text examples appear to work and modification using the new features (while respecting the change in previous behavior) work better.