fix issue with lineSpacing, no space was added between the lines. The co... #1367
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… complete text moved down instead
photonstorm
added a commit
that referenced
this pull request
Nov 25, 2014
fix issue with lineSpacing, no space was added between the lines. The co...
|
👍 |
photonstorm
added a commit
that referenced
this pull request
Nov 25, 2014
…ween the lines (thanks @intimidate #1367 and @brejep #1366)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a very small fix for an annoying problem.
I'm using the following line to add lineSpacing:
this.questionText.lineSpacing = 20;Then this happens:
Here the complete text moves 20px down.
This is what should happen (with the fix):
Here all lines have the correct lineSpacing of 20px.
Example: http://jsfiddle.net/q4r45cxq/