Mouse Scroll Events - added support for WheelEvent, fixes #1318
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added support for the Wheel Event, which is the DOM3 spec. - Wheel Scroll Event (old non-FF) and DOM Mouse Wheel (old FF) are supported via a non-exported reused wrapper object, WheelEventProxy. The proxy methods are generated one-time dynamically; future changes to the Mouse class (such as requiring an opt-in for mouse scroll events) could bypass secondary stub generation. - FIX: Only ONE of the mouse wheel events is listened too, newest standard first. This fixes a bug in FF where it would use the default DOMMouseWheel.
|
thumbsup! |
- The wheel event type is now determined in by Device - The various input checking in Device have been moved to a new function
|
Looks safe enough and useful! Merging now. |
photonstorm
added a commit
that referenced
this pull request
Nov 12, 2014
Mouse Scroll Events - added support for WheelEvent, fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
supported via a non-exported reused wrapper object, WheelEventProxy.
The proxy methods are generated one-time dynamically but only when needed.
This fixes a bug in FF where it would use the default DOMMouseWheel.
This should fix/address #1313