Input - Minor Pointer refactor and documentation updates #1283
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `pointerN` are aliases to backed `pointers[N-1]` array. This simplifies (and increases the efficiency of) looping through all the pointers when applicable; also eliminates pointer-existance checks Removes various hard-coded limits (added MAX_POINTERS); changed `maxPointers` default - Removed some special-casing from cases where it did not matter - Removed `=== false/true`, `==` usage for consistency, changed missing value check to `typeof`, etc. - Updated documentation for specificty; added `@public\@protected` - `@deprecated` currentPointers due to odd set pattern; `totalCurrentPointers` is more appropriate.
photonstorm
added a commit
that referenced
this pull request
Nov 2, 2014
Input - Minor Pointer refactor and documentation updates
photonstorm
added a commit
that referenced
this pull request
Nov 2, 2014
…ecifically:
* pointerN are aliases to backed pointers[N-1] array. This simplifies (and increases the efficiency of) looping through all the pointers when applicable; also eliminates pointer-existance checks Removes various hard-coded limits (added MAX_POINTERS); changed maxPointers default
* Removed some special-casing from cases where it did not matter
* Removed === false/true, == usage for consistency, changed missing value check to typeof, etc.
* Updated documentation for specificty; added @public\@Protected
* @deprecated currentPointers due to odd set pattern; totalCurrentPointers is more appropriate.
(thanks @pnstickne #1283)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pointerNare aliases to backedpointers[N-1]array.This simplifies (and increases the efficiency of) looping through all the pointers when applicable; also eliminates pointer-existance checks
Removes various hard-coded limits (added MAX_POINTERS); changed
maxPointersdefault=== false/true,==usage for consistency, changed missing value check totypeof, etc.@public\@protected@deprecatedcurrentPointers due to odd set pattern;totalCurrentPointersis more appropriate.