Skip to content

Fix for scale issues in CocoonJS using webgl renderer and screencanvas #1064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 31, 2014
Merged

Fix for scale issues in CocoonJS using webgl renderer and screencanvas #1064

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/core/Game.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -586,8 +586,9 @@ Phaser.Game.prototype = {

if (this.device.cocoonJS)
{
// Enable screencanvas for Cocoon on this Canvas object only
this.canvas.screencanvas = true;
// Some issue related to scaling arise with Cocoon using screencanvas and webgl renderer.
// Disabling by default
this.canvas.screencanvas = false;
}

if (this.renderType === Phaser.HEADLESS || this.renderType === Phaser.CANVAS || (this.renderType === Phaser.AUTO && this.device.webGL === false))
Expand Down
6 changes: 3 additions & 3 deletions src/system/Device.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -454,7 +454,7 @@ Phaser.Device.prototype = {

this.file = !!window['File'] && !!window['FileReader'] && !!window['FileList'] && !!window['Blob'];
this.fileSystem = !!window['requestFileSystem'];
this.webGL = ( function () { try { var canvas = document.createElement( 'canvas' ); return !! window.WebGLRenderingContext && ( canvas.getContext( 'webgl' ) || canvas.getContext( 'experimental-webgl' ) ); } catch( e ) { return false; } } )();
this.webGL = ( function () { try { var canvas = document.createElement( 'canvas' ); /*Force screencanvas to false*/ canvas.screencanvas = false; return !! window.WebGLRenderingContext && ( canvas.getContext( 'webgl' ) || canvas.getContext( 'experimental-webgl' ) ); } catch( e ) { return false; } } )();

if (this.webGL === null || this.webGL === false)
{
Expand Down Expand Up @@ -769,7 +769,7 @@ Phaser.Device.prototype = {
}

var image = ctx.createImageData(1, 1);

return image.data instanceof Uint8ClampedArray;

},
Expand Down Expand Up @@ -845,7 +845,7 @@ Phaser.Device.prototype = {
* Check whether the console is open.
* Note that this only works in Firefox with Firebug and earlier versions of Chrome.
* It used to work in Chrome, but then they removed the ability: http://src.chromium.org/viewvc/blink?view=revision&revision=151136
*
*
* @method Phaser.Device#isConsoleOpen
* @return {boolean} True if the browser dev console is open.
*/
Expand Down