Fix Year>>firstThursday #2454
Merged
Fix Year>>firstThursday #2454
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… preceding year. Test case provided. Fixes pharo-project#2453.
|
Note: my signed contributor agreement is in the mail. |
|
Assuming nothing else broke, I agree with this change |
|
I love when fix are proposed with tests!!!! Excellent! |
|
What's wrong with continuous integration? It says that one check failed, but when I click on "Details" it shows no problem at all. |
|
I can see the details and may be you do not have access. The failed tests are not related. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that it never returns a date in the… preceding year.
Test case provided.
Fixes #2453.