Skip to content

Conversation

@Alokzh
Copy link
Contributor

@Alokzh Alokzh commented Sep 2, 2025

Summary:

This pull request significantly enhances the CTKeyedTree implementation. The changes include a massively expanded API, critical bug fixes to recursive methods, improved test coverage, updated Readme & CI workflows

Changes:

  • Expanded API: Added rich set of collection methods (select:, collect:) and tree queries (depth, allPaths, asDictionary) etc
  • Critical Bug Fixes: Corrected the core recursion logic in subtrees, fixing failures in all dependent methods
  • Improved Quality: Increased test coverage & updated the README.md with better examples

@coveralls
Copy link

Pull Request Test Coverage Report for Build 17398400907

Details

  • 325 of 501 (64.87%) changed or added relevant lines in 1 file are covered.
  • 9 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-25.0%) to 64.935%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/Containers-KeyedTree/CTKeyedTree.class.st 325 501 64.87%
Files with Coverage Reduction New Missed Lines %
src/Containers-KeyedTree/CTKeyedTree.class.st 9 64.94%
Totals Coverage Status
Change from base Build 14791748778: -25.0%
Covered Lines: 350
Relevant Lines: 539

💛 - Coveralls

1 similar comment
@coveralls
Copy link

coveralls commented Sep 11, 2025

Pull Request Test Coverage Report for Build 17398400907

Details

  • 325 of 501 (64.87%) changed or added relevant lines in 1 file are covered.
  • 9 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-25.0%) to 64.935%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/Containers-KeyedTree/CTKeyedTree.class.st 325 501 64.87%
Files with Coverage Reduction New Missed Lines %
src/Containers-KeyedTree/CTKeyedTree.class.st 9 64.94%
Totals Coverage Status
Change from base Build 14791748778: -25.0%
Covered Lines: 350
Relevant Lines: 539

💛 - Coveralls

@jordanmontt jordanmontt merged commit e1e4aa4 into pharo-containers:master Sep 11, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants