Add support for PreStop sleep action #44
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fully available starting with Kubernetes v1.31, see kubernetes/enhancements#3960
in Helm-generated YAML
Contributor
Author
|
Thanks for merging this so fast. Would you mind creating a new release of the Helm chart so that we can deploy with this feature more easily? |
|
Hey @levkk, is it possible to release this feature in the near future? |
Contributor
|
Sure thing, will cut a release today! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature is fully available starting with Kubernetes v1.34, see kubernetes/enhancements#3960
This can help prevent errors
57P01"PgDog is shutting down" for client queries, by ensuring clients connect to another PgDog instance before PgDog is actually shut down. During the configured sleep period, Kubernetes will keep the Pod in "Terminating" state while PgDog is still running, accepting and processing queries. Kubernetes removes the Pod IP from the Service immediately, so that clients won't establish new connections to the shutting-down Pod.This works very similar to the
--shutdown-grace-periodparam in ingress-nginx.I also noticed some superfluous newlines in the Helm-generated YAML, which I fixed in a separate commit.