Skip to content

Conversation

Arkatufus
Copy link
Contributor

Expand any exceptions thrown by Azure SubmitTransactionAsync() to include all possible informations about the aborted operation.

Copy link
Member

@Aaronontheweb Aaronontheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nitpick but otherwise looks good

public Akka.Persistence.Azure.Journal.AzureTableStorageJournalSetup Get(string journalId) { }
public void Set(string journalId, Akka.Persistence.Azure.Journal.AzureTableStorageJournalSetup setup) { }
}
public class DatabaseTransactionException : System.Exception
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably needs a more specific name to make it clear that this is coming from the Akka.Persistence.Azure plugin, not some generic thing

Copy link
Member

@Aaronontheweb Aaronontheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Aaronontheweb Aaronontheweb enabled auto-merge (squash) April 7, 2025 19:41
@Aaronontheweb Aaronontheweb merged commit 68d9427 into petabridge:dev Apr 7, 2025
2 checks passed
@Arkatufus Arkatufus deleted the expand-exception-info branch April 7, 2025 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants