Skip to content

Cleanup all async operation during shutdown #249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 23, 2022
Merged

Cleanup all async operation during shutdown #249

merged 2 commits into from
Sep 23, 2022

Conversation

Arkatufus
Copy link
Contributor

@Arkatufus Arkatufus commented Sep 22, 2022 •
edited
Loading

Possible solution for #248

Changes

  • Cleanup async calls by wrapping all async calls with shutdown CancellationTokenSource that gets cancelled and disposed on PostStop() callback

@Arkatufus
Cleanup all async operation during shutdown
acd06fe 
## Changes
- Cleanup async calls by wrapping all async calls with shutdown CTS that gets cancelled and disposed on PostStop
@Arkatufus Arkatufus mentioned this pull request Sep 22, 2022
Closed
@Arkatufus Arkatufus closed this Sep 22, 2022
@Arkatufus Arkatufus reopened this Sep 22, 2022
Aaronontheweb
Aaronontheweb approved these changes Sep 23, 2022
View reviewed changes
Copy link
Member

@Aaronontheweb Aaronontheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Aaronontheweb Aaronontheweb merged commit c22a034 into petabridge:dev Sep 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aaronontheweb Aaronontheweb Aaronontheweb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Arkatufus @Aaronontheweb